Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert unit tests to rspec rather than 'mocha' #554

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Convert unit tests to rspec rather than 'mocha' #554

merged 1 commit into from
Jul 28, 2020

Conversation

KeithWard
Copy link
Contributor

Pull Request (PR) description

Using rspec mocks is preferred over mocha, so update the testsuite to use rspec mocks instead.

This Pull Request (PR) fixes the following issues

Fixes #432

igalic
igalic approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more deletions than additions while swapping out a test suite? 👍

@alexjfisher alexjfisher merged commit 76a971b into voxpupuli:master Jul 28, 2020
@KeithWard KeithWard deleted the convert_mocha_to_rspec branch July 28, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation Warnings - Mocha mock_with
3 participants
@KeithWard @igalic @alexjfisher