Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HTTP_PROXY on bootstrap. #488

Merged
merged 1 commit into from
May 26, 2019
Merged

Allow HTTP_PROXY on bootstrap. #488

merged 1 commit into from
May 26, 2019

Conversation

pillarsdotnet
Copy link
Contributor

@pillarsdotnet pillarsdotnet commented May 22, 2019 •
edited
Loading

Fixes: #469 #473

@pillarsdotnet pillarsdotnet mentioned this pull request May 22, 2019
Closed
Dan33l
Dan33l requested changes May 22, 2019
View reviewed changes
Copy link
Member

@Dan33l Dan33l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @pillarsdotnet i added an inline comment.

manifests/pip/bootstrap.pp Outdated Show resolved Hide resolved
@Dan33l Dan33l added the enhancement New feature or request label May 22, 2019
alexjfisher
alexjfisher requested changes May 22, 2019
View reviewed changes
manifests/pip/bootstrap.pp Outdated Show resolved Hide resolved
manifests/pip/bootstrap.pp Outdated Show resolved Hide resolved
manifests/pip/bootstrap.pp Outdated Show resolved Hide resolved
@pillarsdotnet
Copy link
Contributor Author

@bastelfreak @alexjfisher @Dan33l -- I'm done making changes, and tests passed.

@alexjfisher
Copy link
Member

@pillarsdotnet Thanks, it's looking good. Are you able to add any tests?

@pillarsdotnet
Copy link
Contributor Author

pillarsdotnet commented May 23, 2019 •
edited
Loading

@alexjfisher I could add rspec tests maybe, but I'm not sure they would add any value. For instance, how could we test this ?

Acceptance tests would require setting up a proxy-server, and that's a little too advanced for me.

@pillarsdotnet
Copy link
Contributor Author

Yay! Tests passed!

@bastelfreak
Copy link
Member

Thanks @pillarsdotnet !

@bastelfreak bastelfreak merged commit 4347e91 into voxpupuli:master May 26, 2019
@pillarsdotnet pillarsdotnet deleted the allow_http_proxy_on_bootstrap branch May 27, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@alexjfisher alexjfisher alexjfisher requested changes

@Dan33l Dan33l Dan33l requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pillarsdotnet @alexjfisher @bastelfreak @Dan33l