Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

486 Set permissive umask. #487

Merged
merged 1 commit into from
May 22, 2019
Merged

486 Set permissive umask. #487

merged 1 commit into from
May 22, 2019

Conversation

pillarsdotnet
Copy link
Contributor

Fixes: #486

@pillarsdotnet pillarsdotnet mentioned this pull request May 22, 2019
Merged
Dan33l
Dan33l requested changes May 22, 2019
View reviewed changes
Copy link
Member

@Dan33l Dan33l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pillarsdotnet thank you for the PR.

I added inline comment.

manifests/init.pp Show resolved Hide resolved
@Dan33l
Copy link
Member

Dan33l commented May 22, 2019

@pillarsdotnet please squash the 2 commits into 1

@pillarsdotnet
Copy link
Contributor Author

As requested.

By the way; some projects squash commits when merging and frown on force-pushes because they obscure reviews and comments.

@Dan33l
Copy link
Member

Dan33l commented May 22, 2019

LGTM

@Dan33l Dan33l merged commit 146cdbe into voxpupuli:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dan33l Dan33l Dan33l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should set permissive umask before exec.
2 participants
@pillarsdotnet @Dan33l