-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pip to work in AIX systems #461
Conversation
Some of the files were not expected to be changed at that time |
84834fa
to
635e924
Compare
Awesome work! Noticed that the
|
Finally =) |
Hi @feltra, thanks for all the updates! Could you also add the correct versions for AIX? |
I will have a look. |
metadata.json
Outdated
{ | ||
"operatingsystem": "AIX", | ||
"operatingsystemrelease": [ | ||
"6100", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
facter operatingsystemrelease
returns 6100
instead of 6.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{name => AIX, family => AIX, release => {major => 6100-09-11-1810, full => 6100-09-11-1810}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep this with family only and then handle the releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return from operatingsystem release is 6100-09-11-1810..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrm this is pretty crappy from facter :(
@ghoneycutt do you think we should keep the current version of the metadata or update it to the actual value from facter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see for gentoo we don't care for release as well..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't care for the versions on Gentoo and Archlinux because those are rolling release distributions. For everything else we have to care about it. Based on this data, the facts are mocked during the tests (and some other stuff).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copy/pasted above from puppetlabs/stdlib. Suggest we use that format since that's what they use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. IMO we can merge this as soon as we get travis green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick sampling of the Forge also shows using 'X.Y' format
@feltra can you take a look at the failing travis jobs? |
74e5af6
to
3a3026e
Compare
thanks! |
@feltra please also think about adding the facts to https://github.com/camptocamp/facterdb <3 |
This changes allow installing python and pip modules, assuming that you have yum previously configured as per described at
https://www.ibm.com/developerworks/aix/library/aix-toolbox/date.html
It have been tested on AIX 6 and 7
Pull Request (PR) description
This Pull Request (PR) fixes the following issues