Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pip to work in AIX systems #461

Merged
merged 10 commits into from
Jan 18, 2019

Conversation

feltra
Copy link
Contributor

@feltra feltra commented Jan 15, 2019

This changes allow installing python and pip modules, assuming that you have yum previously configured as per described at
https://www.ibm.com/developerworks/aix/library/aix-toolbox/date.html
It have been tested on AIX 6 and 7

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

manifests/install.pp Outdated Show resolved Hide resolved
manifests/install.pp Outdated Show resolved Hide resolved
manifests/params.pp Outdated Show resolved Hide resolved
manifests/pip.pp Outdated Show resolved Hide resolved
@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Jan 15, 2019
@feltra
Copy link
Contributor Author

feltra commented Jan 15, 2019

Some of the files were not expected to be changed at that time

@feltra feltra force-pushed the make_it_aix_compatible branch from 84834fa to 635e924 Compare January 15, 2019 01:31
@ghoneycutt
Copy link
Member

Awesome work! Noticed that the metadata.json still needs to be updated. Something like the following.

    {
      "operatingsystem": "AIX",
      "operatingsystemrelease": [
        "6.1",
        "7.1",
        "7.2"
      ]
    }

@feltra
Copy link
Contributor Author

feltra commented Jan 15, 2019

Finally =)

@bastelfreak bastelfreak removed the needs-work not ready to merge just yet label Jan 15, 2019
@bastelfreak
Copy link
Member

Hi @feltra, thanks for all the updates! Could you also add the correct versions for AIX?
It would be really really awesome, if you could contribute AIX facts to the facterdb project:
https://github.com/camptocamp/facterdb

@feltra
Copy link
Contributor Author

feltra commented Jan 15, 2019

I will have a look.
Thanks

metadata.json Outdated
{
"operatingsystem": "AIX",
"operatingsystemrelease": [
"6100",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facter operatingsystemrelease returns 6100 instead of 6.1 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{name => AIX, family => AIX, release => {major => 6100-09-11-1810, full => 6100-09-11-1810}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this with family only and then handle the releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return from operatingsystem release is 6100-09-11-1810..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm this is pretty crappy from facter :(
@ghoneycutt do you think we should keep the current version of the metadata or update it to the actual value from facter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see for gentoo we don't care for release as well..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't care for the versions on Gentoo and Archlinux because those are rolling release distributions. For everything else we have to care about it. Based on this data, the facts are mocked during the tests (and some other stuff).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy/pasted above from puppetlabs/stdlib. Suggest we use that format since that's what they use.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. IMO we can merge this as soon as we get travis green.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick sampling of the Forge also shows using 'X.Y' format

@bastelfreak
Copy link
Member

@feltra can you take a look at the failing travis jobs?

@feltra feltra force-pushed the make_it_aix_compatible branch from 74e5af6 to 3a3026e Compare January 17, 2019 13:39
@bastelfreak
Copy link
Member

thanks!

@bastelfreak bastelfreak merged commit 995ca4e into voxpupuli:master Jan 18, 2019
@bastelfreak
Copy link
Member

@feltra please also think about adding the facts to https://github.com/camptocamp/facterdb <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants