Replace deprecated validate_* functions #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurmatt
force-pushed
the
fix/validate_function_deprecation
branch
from
7d50e03 to
2a706db
Compare
ekohl
reviewed
Oct 26, 2018
| #} | ||
| validate_re($version, concat(['system', 'pypy'], $valid_versions)) | ||
| $allowed_versions = concat(['system', 'pypy'], $valid_versions) | ||
| unless $version =~ Enum[$allowed_versions] { |
There was a problem hiding this comment.
Should this be unless $version in $allowed_versions if it's an array? Not sure what the data type of $valid_versions is.
There was a problem hiding this comment.
$valid_versions, when taken from python::params, is an array. But even if it would be a string, the concat() would generate an array for $allowed_versions. I guess one could also use the in syntax you suggested. Not sure that the performance difference is.
|
Is there a better way to verify data type errors then matching it with a Regex? Because for some reasons the output changes between Puppet 4,5 and 6.... |
baurmatt
force-pushed
the
fix/validate_function_deprecation
branch
from
2a706db to
583d68f
Compare
|
Sorry, this may now have some conflicts now that I merged #440 |
baurmatt
force-pushed
the
fix/validate_function_deprecation
branch
from
583d68f to
13b725d
Compare
|
No worries! :) Rebased the branch. |
|
Thanks for the PR @baurmatt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues