Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single quotation for pip url #429

Closed
wants to merge 1 commit into from

Conversation

onstring
Copy link

@onstring onstring commented Sep 6, 2018

Will fix the pip installation issue when url is git+https://github.com/xxxxxxxx#egg=yyyy

@alexjfisher
Copy link
Member

@danquack
Copy link
Contributor

danquack commented Sep 6, 2018

@onstring you can proabably fix the robocop errors with bundle exec rake rubocop:auto_correct

@bastelfreak
Copy link
Member

mhm, would an acceptance test be helpful here?

@onstring onstring closed this Nov 29, 2018
@onstring onstring reopened this Nov 29, 2018
@onstring
Copy link
Author

onstring commented Nov 29, 2018

The patch is fixing the problem when pip url is like git+https://github.com/xxxxxxxx#egg=yyyy

Copy link
Contributor

@pillarsdotnet pillarsdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alexjfisher
Copy link
Member

and https://github.com/voxpupuli/puppet-python/pull/429/files#diff-8a5246728de7306981fd3fa2191bd8eaR214 ? This would have matched previously (when $source == $url), but won't anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants