Fix puppet-lint issue from f6d4b30 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there were additional errors hidden behind the lint issue. Lemme see if I can figure them out. |
|
Cool! |
shivapoudel
added a commit
that referenced
this pull request
Jun 13, 2015
Fix puppet-lint issue from f6d4b30
|
Ya, I'm not too sure how to run the rspec tests locally (I'm not very familiar with rspec) so I think resolving the other issues is beyond my ability. @shivapoudel can you point me to the steps to go from nothing to being able to run the rspec tests and get the same errors that travis-ci is reporting? |
|
Not sure if I'll have time now. Can you do it @petems :P |
|
Sure, it's basically an issue with 1.8.7 and facter running twice. It's something to do with |
shivapoudel
pushed a commit
that referenced
this pull request
Sep 1, 2015
Fix puppet-lint issue from f6d4b30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Travis-CI builds are failing due to puppet-lint from f6d4b30 . This should get the builds passing again.