Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL 8 support #364

Merged
merged 4 commits into from
Feb 5, 2020
Merged

Add RHEL 8 support #364

merged 4 commits into from
Feb 5, 2020

Conversation

yakatz
Copy link
Member

@yakatz yakatz commented Nov 26, 2019

Redhat 8 has made a number of changes to openvpn.

  • easy-rsa not yet available in EPEL - tracking in https://bugzilla.redhat.com/show_bug.cgi?id=1776676
  • Server and client configurations are now expected to be in /etc/openvpn/server/ and /etc/openvpn/client. Initial attempt to add default-empty string or server/` string doesn't pass tests.

@Dan33l Dan33l added enhancement New feature or request tests-fail needs-work not ready to merge just yet labels Nov 26, 2019
@yakatz
Copy link
Member Author

yakatz commented Nov 26, 2019

Need epel module to support Centos 8 for tests to be able to pass. There is a pull request already merged, but a new release hasn't been made yet. voxpupuli/puppet-epel#91

@yakatz
Copy link
Member Author

yakatz commented Nov 27, 2019

Update from EPEL Bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1776676

Fedora Update System [email protected] changed:

       What    |Removed                     |Added

         Status|NEW                         |MODIFIED

--- Comment #1 from Fedora Update System [email protected] ---
FEDORA-EPEL-2019-3a27bd13c0 has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-3a27bd13c0

@yakatz
Copy link
Member Author

yakatz commented Dec 16, 2019

Bugzilla says:

easy-rsa-3.0.6-2.el8 has been pushed to the Fedora EPEL 8 stable repository.

Still waiting on voxpupuli/puppet-epel#91

@vox-pupuli-tasks
Copy link

Dear @yakatz, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @yakatz, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@yakatz
Copy link
Member Author

yakatz commented Jan 9, 2020

I haven't abandoned this pull request, but I can't do anything else until EPEL support is ready. Would it be totally crazy to fork and republish the EPEL module to allow the tests to pass?

@yakatz
Copy link
Member Author

yakatz commented Jan 21, 2020

Back to all the tests working except RHEL8. We don't use easy-rsa internally, but I will keep investigating.

EDIT: Woops - forgot I disabled it when EPEL wasn't available.

@yakatz yakatz changed the title WIP: RHEL 8 support RHEL 8 support Jan 21, 2020
@yakatz yakatz requested review from Dan33l and bastelfreak and removed request for Dan33l January 21, 2020 07:22
@bastelfreak bastelfreak removed needs-work not ready to merge just yet tests-fail labels Jan 30, 2020
@bastelfreak
Copy link
Member

thanks for the work!

@bastelfreak
Copy link
Member

Can you please add CentOS/RHEL 8 to the metadata.json? Afterwards we should be able to merge this.

@bastelfreak bastelfreak added the needs-work not ready to merge just yet label Jan 30, 2020
@yakatz
Copy link
Member Author

yakatz commented Feb 3, 2020

Looks like I have more tests to fix with the updated metadata

@bastelfreak bastelfreak changed the title RHEL 8 support Add RHEL 8 support Feb 4, 2020
With working tests
@bastelfreak bastelfreak removed the needs-work not ready to merge just yet label Feb 5, 2020
@bastelfreak
Copy link
Member

thanks for the awesome work!

@bastelfreak bastelfreak merged commit 78ea72e into voxpupuli:master Feb 5, 2020
@yakatz yakatz deleted the feature/rhel8 branch February 5, 2020 15:18
@yakatz
Copy link
Member Author

yakatz commented Feb 5, 2020

@bastelfreak Any idea when this would make it into a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants