Add option to disable ordering dependencies on Openvpn::Client #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluewind
force-pushed
the
openvpn-client-config
branch
from
72e419f to
2095523
Compare
sebastianrakel
approved these changes
Jul 16, 2019
|
Hi @Bluewind . Can you explain a use case ? |
|
We have a setup where we manage client certificates outside of puppet and we'd like to migrate our servers to this module. We are perfectly fine with managing the certificates with our existing workflow. Since we do not need it, we do not configure a Edit: I've updated the commit message accordingly. |
We have a setup where we manage client certificates outside of puppet and we'd like to migrate our servers to this module. We are perfectly fine with managing the certificates with our existing workflow. Since we do not need it, we do not configure a `Client[$name]` resource for the matching `Client_specific_config[$name]`, but currently this code results in an error because it expects such a resource to be defined. Resolve this by making the ordering dependency optional. Signed-off-by: Florian Pritz <[email protected]>
Bluewind
force-pushed
the
openvpn-client-config
branch
from
2095523 to
59a6c89
Compare
Dan33l
reviewed
Jul 16, 2019
Dan33l
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Florian Pritz [email protected]