Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally manage logfile parent directory #343

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

Bluewind
Copy link
Contributor

@Bluewind Bluewind commented Jul 4, 2019

If the logfile path is set to a subdir (e.g.
/var/log/openvpn/$name/openvpn.log) someone needs to create that path.
This is a good a place as any to add that feature.

Signed-off-by: Florian Pritz [email protected]

If the logfile path is set to a subdir (e.g.
/var/log/openvpn/$name/openvpn.log) someone needs to create that path.
This is a good a place as any to add that feature.

Signed-off-by: Florian Pritz <[email protected]>
Copy link
Member

@sebastianrakel sebastianrakel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it should create dirs recursive if i have some more grouping on my logs

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Aug 3, 2019
Copy link
Member

@Dan33l Dan33l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dan33l Dan33l merged commit 24ed209 into voxpupuli:master Aug 6, 2019
@Bluewind Bluewind deleted the manage-logfile-dir branch August 6, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants