Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use double quotes on all push options #330

Merged
merged 1 commit into from
Feb 25, 2019
Merged

use double quotes on all push options #330

merged 1 commit into from
Feb 25, 2019

Conversation

qs5779
Copy link
Contributor

@qs5779 qs5779 commented Feb 24, 2019

Pull Request (PR) description

Added double quotes to push options which did not have double quote

This Pull Request (PR) fixes the following issues

Fixes issue #329

@Dan33l
Copy link
Member

Dan33l commented Feb 25, 2019

Hey @qs5779 thank you for the PR.
Are you able to squash 2 commits into only one ?

@Dan33l
Copy link
Member

Dan33l commented Feb 25, 2019

Nice @qs5779 .
I apologize, but now it is better to change the comment of commit to be related to what is changed.

@Dan33l Dan33l merged commit 8c68e67 into voxpupuli:master Feb 25, 2019
@Dan33l Dan33l added the bug Something isn't working label Feb 25, 2019
@Dan33l Dan33l mentioned this pull request Feb 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dan33l Dan33l Dan33l approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qs5779 @Dan33l