Remove conditional statements #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jameskirsop all acceptance tests on nodes running EasyRSA v3 are failing. IMO, the issue is that the command used in resource So the fix should be, with custom fact Can you modify the PR in this way ? |
|
If you need help fill free to ask. You can also join #voxpupuli on IRC and slack. |
|
The issue is now closed by PR #321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR removes the conditional statements around two environment variables so that they are always set. In doing so it allows the auto crl renewal process to succeed if either of the two options are missing in the
openvpn::serverdeclaration.This Pull Request (PR) fixes the following issues
Fixes #318