Set DH timeout to accommodate low performance CPU #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dan33l
requested changes
Dec 11, 2018
There was a problem hiding this comment.
hi @dspinellis thank you for the PR.
Can you have a look at the inline comment ?
Excepted this, the PR LGTM.
|
Good point; I added it. |
|
@dspinellis please squash your commits and the PR will be merged when CI will be successfully finished. |
On a Raspberry Pi B+ the Diffie-Hellman parameter generation for a 2048 key was measured to take 229m45.379s wall clock time. Set the respective command's timeout 50% above this, to prevent the corresponding rule from timing out. Add missing timeout for EasyRSA 3.0
dspinellis
force-pushed
the
dh-timeout
branch
from
a84b77e to
46d4699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set DH timeout to accommodate computers with a low performance CPU
On a Raspberry Pi B+ the Diffie-Hellman parameter generation for
a 2048 key was measured to take 229m45.379s wall clock time.
Set the respective command's timeout 50% above this, to prevent
the corresponding rule from timing out.
This Pull Request (PR) fixes the following issues
Fixes #316