prohibit empty string for $compression #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
changed the title
bastelfreak
force-pushed
the
compression_fix
branch
from
53c7ae3 to
1f3e1a9
Compare
bastelfreak
changed the title
alexjfisher
requested changes
Oct 21, 2018
| @@ -195,7 +195,7 @@ | |||
| # | |||
| define openvpn::client ( | |||
| String $server, | |||
| String $compression = 'comp-lzo', | |||
| Optional[String[1]] $compression = 'comp-lzo', | |||
There was a problem hiding this comment.
Since it doesn’t default to undef, how am I supposed to set it to undef?
There was a problem hiding this comment.
a call of the defined type like this ?
openvpn::client { 'myclient':
compression => undef,
...
}
There was a problem hiding this comment.
Nope. If you do that, it'll use the default value.
Closed
|
Done in PR #333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues