Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: change additional_packages to easy-rsa2 #301

Merged
merged 1 commit into from
Oct 16, 2018
Merged

FreeBSD: change additional_packages to easy-rsa2 #301

merged 1 commit into from
Oct 16, 2018

Conversation

olevole
Copy link

@olevole olevole commented Oct 15, 2018

the default easy-rsa package in FreeBSD gets easy-rsa 3.0.5
which for some reason does not work correctly in puppet-openvpn
under FreeBSD platform ( of course with changed $default_easyrsa_ver )
Therefore, temporarily specify the correct easy-rsa 2x package name
for FreeBSD: https://www.freshports.org/security/easy-rsa2/

I will try to look soon for easy-rsa 3.0.5 and puppet-openvpn error
with FreeBSD platform.

Tested on:
FreeBSD 11
FreeBSD 12
( Puppet client: puppet5-5.5.6, Puppet server: 5.3.5 )

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

the default easy-rsa package in FreeBSD gets easy-rsa 3.0.5
which for some reason does not work correctly in puppet-openvpn
under FreeBSD platform ( of course with changed $default_easyrsa_ver )
Therefore, temporarily specify the correct easy-rsa 2x package name
for FreeBSD: https://www.freshports.org/security/easy-rsa2/

I will try to look soon for easy-rsa 3.0.5 and puppet-openvpn error
with FreeBSD platform.

Tested on:
  FreeBSD 11
  FreeBSD 12
  ( Puppet client: puppet5-5.5.6, Puppet server: 5.3.5 )
@Dan33l
Copy link
Member

Dan33l commented Oct 16, 2018

Hey @olevole thank you for the PR.

I am not sure to understand. The name of the package changed , the version of easyrsa changed or both ?

@olevole
Copy link
Author

olevole commented Oct 16, 2018

Hey @olevole thank you for the PR.

I am not sure to understand. The name of the package changed , the version of easyrsa changed or both ?

easyrsa package at the moment ( and the last two years ) is 3.x.x:

https://svnweb.freebsd.org/ports?view=revision&revision=r405813
https://svnweb.freebsd.org/ports/head/UPDATING?r1=405813&r2=405812&pathrev=405813

I am currently seeing some problems with easyrsa3 + puppet-openvpn, so I preferred to specify correct package name for easyrsa 2.x.x and stay with $default_easyrsa_ver=2 some more time

@Dan33l
Copy link
Member

Dan33l commented Oct 16, 2018

So, what i am understanding is that since FreeBSD provides easyrsa version 3 :

  • package easyrsa is for version 3
  • package easyrsa2 is for version 2

And because of problems you encountered with this module and easyrsa3 on FreeBSD, your PR does not modify $default_easyrsa_ver.

We do not have acceptance with this OS. I prefer to be sure to understand.

@olevole
Copy link
Author

olevole commented Oct 16, 2018

@Dan33l Yes, that's right, easyrsa3 is another story. By this PR we will only fix the puppet-openvpn module for FreeBSD (with easyrsa2).

@Dan33l Dan33l merged commit fc66f9e into voxpupuli:master Oct 16, 2018
@Dan33l
Copy link
Member

Dan33l commented Oct 16, 2018

Feel free to propose a PR about easyrsa version 3 on FreeBSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants