Breaking: Update puppet, stdlib, and concat requirements in prep for release #242
Conversation
|
We should probably switch to P4 data types + switch empty strings to undefs before the release. |
|
can you check the mergeconflicts? |
|
@bastelfreak: rebased. Also have a WIP with data types, but have a few questions to address. |
.fixtures.yml
Outdated
| @@ -2,10 +2,10 @@ fixtures: | |||
| repositories: | |||
| stdlib: | |||
| repo: git://github.com/puppetlabs/puppetlabs-stdlib | |||
| ref: '4.6.0' | |||
| ref: '4.20.0' | |||
There was a problem hiding this comment.
As on the other PR: We should unpin those modules.
metadata.json
Outdated
| "name": "puppetlabs/stdlib", | ||
| "version_requirement": ">= 1.0.0 < 5.0.0" | ||
| "name": "puppetlabs/concat", | ||
| "version_requirement": ">= 4.0.0 < 5.0.0" |
There was a problem hiding this comment.
And reason this wouldn't work with an older concat? In general it's nice to have the option to use an older version in case other modules aren't allowing 4.0.0 yet.
There was a problem hiding this comment.
@ekohl It probably still would -- however, once we stop testing against it, may be hard to assert that it still works with it. In general, we tend to drop support for older versions of stuff in modules, but I'm happy to set it to whatever makes sense.
nginx is using ">= 3.0.0 <5.0.0"
There was a problem hiding this comment.
@bastelfreak do you want me to back it down to 3.0?
There was a problem hiding this comment.
3.0 seems to be fine. 4.0 just added datatypes, but has the same functionality
README.md
Outdated
| @@ -29,12 +29,12 @@ Puppet module to manage OpenVPN servers and clients. | |||
| * Amazon | |||
|
|
|||
| ## Dependencies | |||
| - [puppetlabs-concat 1.0.1+](https://github.com/puppetlabs/puppetlabs-concat) | |||
| - [puppetlabs-stdlib 1.0.0+](https://github.com/puppetlabs/puppetlabs-stdlib) | |||
| - [puppetlabs-concat 4.0.0+](https://github.com/puppetlabs/puppetlabs-concat) | |||
There was a problem hiding this comment.
@wyardley can you add here 3.0.0 as well pls?
|
@bastelfreak is this looking good now? |
Open to suggestions on whether to do another release immediately or to merge some stuff first.