Update validation for EL 6. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing CI checks are from upstream and not from the PR. |
|
@bastelfreak I think this needs another modulesync. |
|
Hi @loopiv. Please rebase against the current master. |
|
Just rebased. |
|
@loopiv could you take a look at the failed test? That one is related to your change? |
|
Sorry, should have looked at the tests earlier. Updated the spec test and things seems OK now. If it looks good on your end, should I rebase/squash? |
|
yes, please squash. |
Nodesource now supports branches 4.x and 5.x for EL6. Updated validation of $repo_url_suffix to allow these suffixes. Updated spec test for EL6 for 5.x branch.
|
thx for the contribution! |
|
Sure thing. My first PR! Thanks a bunch for the module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodesource now supports branches 4.x and 5.x for EL6. Updated
validation of $repo_url_suffix to allow these suffixes.