Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-default (i.e. 0.12) versions on RedHat #159

Closed
jantman opened this issue Aug 13, 2015 · 6 comments
Closed

Support non-default (i.e. 0.12) versions on RedHat #159

jantman opened this issue Aug 13, 2015 · 6 comments
Labels
enhancement New feature or request

Comments

@jantman
Copy link

jantman commented Aug 13, 2015

Nodesource has 0.12 RPMs available for RedHat, but this module doesn't seem to support them. The RPMs are available at: https://rpm.nodesource.com/pub_0.12/el/7/x86_64/

However, the module has the /pup/ directory hard-coded which will always give 0.10. This is supported on Debian. It should be supported on RedHat as well.

jantman added a commit to jantman/puppet-nodejs that referenced this issue Aug 13, 2015
@jantman
Copy link
Author

jantman commented Aug 13, 2015

WIP in a branch of mine, will be testing shortly.

@tommymcgahee
Copy link

Any updates on your WIP branch, jantman? I pulled your commit down to my Puppet master but this happens whenever I make a catalog request from my agent:

Notice: /Stage[main]/Nodejs::Repo::Nodesource::Yum/Yumrepo[nodesource]/baseurl: baseurl changed 'https://rpm.nodesource.com/node_0.12/el/6/$basearch' to 'https://rpm.nodesource.com/pub/el/6/$basearch'
Notice: /Stage[main]/Nodejs::Repo::Nodesource::Yum/Yumrepo[nodesource-source]/baseurl: baseurl changed 'https://rpm.nodesource.com/node_0.12/el/6/SRPMS' to 'https://rpm.nodesource.com/pub/el/6/SRPMS'
Notice: /Stage[main]/Nodejs::Install/Package[nodejs]/ensure: created
Notice: Finished catalog run in 17.69 seconds

@igalic
Copy link
Contributor

igalic commented Sep 21, 2015

@jantman ping


@tommymcgahee, if @jantman doesn't respond, could you take this over, and submit his patch as pull request?

@tommymcgahee
Copy link

@igalic I ended up creating a custom module using this package's npm.rb and grabbing the rpm from nodesource and installing via yum. Very rudimentary, but it got the job done. You can see it here - https://github.com/tommymcgahee/puppet-and-ci-managed-dev-environments/tree/puppet-master-foreman/modules/custom_node_npm

@juniorsysadmin
Copy link
Member

#174

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Nov 16, 2015
@juniorsysadmin
Copy link
Member

Fixed by #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants