Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax highlighting for hash value in string #66

Open
robturtle opened this issue Jul 26, 2016 · 2 comments
Open

syntax highlighting for hash value in string #66

robturtle opened this issue Jul 26, 2016 · 2 comments

Comments

@robturtle
Copy link

robturtle commented Jul 26, 2016

In the string, a normal variable can be highlighted correctly (e.g. $id, ${id}), but if a variable containing brackets (say ${facts['id']}) it will be highlighted like other literal string characters. Here is the example screenshot:

image

@swsnr
Copy link
Contributor

swsnr commented Jul 26, 2016

@robturtle Hello. Thank you for reporting this issue.

Please do take the time to write a proper report, though. At least add a verbal description of the highlighting flaw, better yet add a screenshot that shows how the highlighting is broken. Describe what you'd expect instead.

And maybe do take the time to say hello. We're no machines and appreciate a little courtesy at whiles.

In any case I do not have time to work on this mode, not now and not anytime soon. I'm sorry but I don't use Puppet anymore and have quite different priorities.

Please feel free to take a look. Pull requests are very welcome.

@robturtle
Copy link
Author

Sorry for being an idiot. Allow me explain a little bit -- at the time I'm writing this issue my laptop is about to power off so I decide to push it out as a placeholder and rephrase it later. And of cause I didn't expect you responding so fast. I will reformat my issue right now. I know nothing about elisp but I will try my best to figure out a PR for that. Thank you again for your quick response and attention.

On Jul 26, 2016, at 4:12 PM, Sebastian Wiesner [email protected] wrote:

@robturtle https://github.com/robturtle Hello. Thank you for reporting this issue.

Please do take the time to write a proper report, though. At least add a verbal description of the highlighting flaw, better yet add a screenshot that shows how the highlighting is broken. Describe what you'd expect instead.

And maybe do take the time to say hello. We're no machines and appreciate a little courtesy at whiles.

In any case I do not have time to work on this mode, not now and not anytime soon. I'm sorry but I don't use Puppet anymore and have quite different priorities.

Please feel free to take a look. Pull requests are very welcome.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #66 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ADXGHRlPpZC9B9RNZ7pFWjVGctAc_PTcks5qZmo2gaJpZM4JVerw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants