Add force binary #227
Add force binary #227
Conversation
this options helps to deploy the glusterfs-server with volume creation on its first puppet run.
… into add_force_binary
|
@bastelfreak are you able to Aprove the Workflow? |
… into add_force_binary
|
@bastelfreak i've reviewed the spec test errors and fixed them. Also i removed CentOS6 from the metadata.json becaus the spec test will always fail, CentOS 6 is EOL since 4 Years and the Maintancen Updates also have been remove at Nov 2020. |
| ) { | ||
| # we can't do much without the Gluster binary | ||
| # but we don't necessarily want the Puppet run to fail if the | ||
| # gluster_binary fact is absent! | ||
| if getvar('::gluster_binary') { | ||
| if($force_binary) { | ||
| $real_binary = getvar('::gluster_binary') ? { |
There was a problem hiding this comment.
what's the purpose of this workaround? The fact we have in https://github.com/voxpupuli/puppet-gluster/blob/master/lib/facter/gluster.rb checks if the binary gluster exists in $PATH.
There was a problem hiding this comment.
This getvar() stuff do not work at the first puppet run. So if the Server should be deployed with only 1 puppet agent run the glusterfs volume and peers won't be createt. With this workaround the binary variable will be set to the correct value so at the first run the peers an volumes could be created.
There was a problem hiding this comment.
while this approach might works, it's really tricky to read and I think we don't use a manual lookup() + hiera in modules just to get a single value. Instead of all this code we could add another parameter like this:
Stdlib::Absolutepath $gluster_binary = pick($facts['gluster_binary'], '/usr/sbin/gluster')There was a problem hiding this comment.
I will try the Stdlib version in my Test ENV.
I'll added the hiera stuff as a beginning to start removing the cases stuff from the pramas classes. But this i would add in extra branches/PRs
|
@bastelfreak i've closed here and added a new PR (#228) in that there is a full hiera tree without params.pp and also added RHEL8 support. |
needed if we've to deploy the whole gluster server in one Run.
Pull Request (PR) description
We needed the posibility to deploy the glusterfs-server at the first run, this won't work actually. So I've added the variable to force the binary path and disables the getvar() for the first run. With this we are able to add the Peers and Volume at the first run.
This Pull Request (PR) fixes the following issues
n/a