Add a sleep between tries of consul service reload #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I never understood why we have this exec resource. Can't we send a notify to the service resource? |
|
The original intent was to make it so we could do a lighter weight |
|
@cmd-ntrf can you add a trailing comma and rebase on master? |
As expressed issue voxpupuli#231, consul reload will fails if it happens while consul is still booting. However, the addition of multiple tries does not solve the issue as all tries can occur in a very short lapse of time. In this PR, we introduce a sleep between each try, leaving consul up to 20 seconds between the first and the last reload to complete its boot, which should be enough.
cmd-ntrf
force-pushed
the
reload_try_sleep
branch
from
ddc1e87
to
d82f303
Compare
|
done. |
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
Add a sleep between tries of consul service reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As expressed issue #231, consul reload will fails if it happens while consul is still booting. However, the addition of multiple tries does not solve the issue as all tries can occur in a very short lapse of time.
In this PR, we introduce a sleep between each try, leaving consul up to 20 seconds between the first and the last reload to complete its boot, which should be enough.