new facts for 4.3 and 4.4 and a few stragglers for 4.1 #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
May 1, 2023
| for puppet_agent_version in 6.2 6.4 6.6; do | ||
| # as of 2023-04-27 older 6.x series aren't available (i.e. facter 3.12) | ||
| # the trailing dot is so that 6.4.* is the match so we get the last in the 6.4 series and not 6.40 | ||
| for puppet_agent_version in 6.4. 6.28.; do |
There was a problem hiding this comment.
given that Puppet 6 is EoL I would be fine with dropping the whole logic after we merged this PR.
bastelfreak
approved these changes
May 1, 2023
|
In case someones cycles back to this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sles 12 facts were manually generated, zypper was unhappy about a variety of keys