This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Drop Ruby 2.5/2.6 support; use voxpupuli-rubocop #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 1 1
Lines 98 98
=======================================
Hits 92 92
Misses 6 6 ☔ View full report in Codecov by Sentry. |
tuxmea
approved these changes
May 5, 2023
jay7x
reviewed
May 5, 2023
| @@ -45,7 +43,7 @@ jobs: | |||
| ruby-version: ${{ matrix.ruby }} | |||
| bundler-cache: true | |||
| - name: spec tests | |||
| run: bundle exec rake | |||
| run: bundle exec rake spec | |||
| - name: Build gem | |||
| run: gem build *.gemspec | |||
There was a problem hiding this comment.
should there be --strict --verbose?
jay7x
approved these changes
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.