fix: tests

voxmedia · Mar 2, 2021 · 7a7ca58 · 7a7ca58
1 parent 3ce992c
commit 7a7ca58
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/__tests__/utils.spec.js b/__tests__/utils.spec.js
@@ -1,5 +1,6 @@
 import { formatChannelName, buildSlackAttachments } from '../src/utils';
 import { GITHUB_PUSH_EVENT, GITHUB_PR_EVENT } from '../fixtures';
+const runId = parseInt(process.env.GITHUB_RUN_ID, 10);
 
 describe('Utils', () => {
   describe('formatChannelName', () => {
@@ -35,7 +36,7 @@ describe('Utils', () => {
 
         expect(attachments[0].fields.find(a => a.title === 'Workflow')).toEqual({
           title: 'Workflow',
-          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/${process.env.GITHUB_JOB} | CI>`,
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/${runId} | CI>`,
           short: true,
         });
       });
@@ -45,7 +46,7 @@ describe('Utils', () => {
 
         expect(attachments[0].fields.find(a => a.title === 'Job')).toEqual({
           title: 'Job',
-          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/${process.env.GITHUB_JOB} | build and push>`,
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/${runId} | build and push>`,
           short: true,
         });
       });
@@ -77,7 +78,7 @@ describe('Utils', () => {
 
         expect(attachments[0].fields.find(a => a.title === 'Workflow')).toEqual({
           title: 'Workflow',
-          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/${process.env.GITHUB_JOB} | CI>`,
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/${runId} | CI>`,
           short: true,
         });
       });

diff --git a/fixtures.js b/fixtures.js
@@ -14,8 +14,6 @@ export const GITHUB_PUSH_EVENT = {
     workflow: 'CI',
     eventName: 'push',
     sha: 'abc123',
-    job: 'build and push',
-    runId: 12345,
   },
 };
 
@@ -35,7 +33,5 @@ export const GITHUB_PR_EVENT = {
     workflow: 'CI',
     eventName: 'pull_request',
     sha: 'abc123',
-    job: 'build and push',
-    runId: process.env.GITHUB_JOB,
   },
 };