-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add fo.SampleReference as a way to reference other samples in other datasets #5277
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
What changes are proposed in this pull request?
I created a rough proof of concept for my SampleReference idea proposed here. If the general idea is accepted, I will continue to improve and cleanup the PR.
#5275
Some initial benchmarks in sample_reference_benchmark.py, with a large polyline base dataset
How is this patch tested? If it is not, please explain why.
Added a basic test case confirming basic functionality. I will add more tests to catch other edge cases.
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes