Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/v1.2.0 to develop #5276

Merged
merged 58 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
285145b
Fixed Hugging Face Transformers not using GPU
danielgural Oct 24, 2024
3d6084f
Fixed some classes not having device on them
danielgural Oct 24, 2024
038138e
optimize main thread to worker transfer when recoloring
sashankaryal Dec 9, 2024
ece501a
fix typo
sashankaryal Dec 9, 2024
89fea41
check if array buffer detached
sashankaryal Dec 10, 2024
d3bf174
add clarifying comments
sashankaryal Dec 10, 2024
4f76488
cleanup overlays in the worker listener callback instead
sashankaryal Dec 12, 2024
1510b47
remove bitmap = null (obj closed for modification)
sashankaryal Dec 12, 2024
e22b56e
remove unnecessary sample null check guard
sashankaryal Dec 12, 2024
686be45
fix #5254
brimoor Dec 13, 2024
d41fffc
TP/FP/NP support for binary classification model evaluation
imanjra Dec 13, 2024
f627b82
Merge pull request #5267 from voxel51/model-eval-fixes
brimoor Dec 13, 2024
c702bb2
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 13, 2024
981c42d
include all labels in views
brimoor Dec 13, 2024
a9ea1c3
filtering comparison field as well
brimoor Dec 15, 2024
35f15b2
Merge pull request #5247 from voxel51/fix/transfer-bitmaps-back
sashankaryal Dec 17, 2024
a8e5a3f
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 17, 2024
8997a39
consistent table heading row text style
imanjra Dec 16, 2024
7c51825
fix evaluation timestamp
imanjra Dec 16, 2024
4cdeff0
hide unsupported metrics in model eval panel
imanjra Dec 16, 2024
09bb793
gracefully handle unsupported model evaluation
imanjra Dec 16, 2024
a78dd41
use mask targets in model evaluation panel
imanjra Dec 6, 2024
0db34b4
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 17, 2024
1ddd2bf
do not add valid list field filters to collapsed paths (#5280)
benjaminpkane Dec 17, 2024
a7ab1d9
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 17, 2024
f704079
add extended selection (#5286)
benjaminpkane Dec 17, 2024
8ee8647
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 17, 2024
9c3cb74
add detections fields to additional media fields
sashankaryal Dec 17, 2024
bd7d2de
use pydash.get instead of _deep_get
sashankaryal Dec 17, 2024
d0462b9
use detections fields in media urls creation, too
sashankaryal Dec 17, 2024
89d1853
add support for collection overlay types in disk decoder
sashankaryal Dec 17, 2024
d2038b0
return if no path
sashankaryal Dec 17, 2024
cd8eaee
fix src bug
sashankaryal Dec 17, 2024
5d6f683
add clarification comment for sources
sashankaryal Dec 17, 2024
bc44e3e
don't get rid of query params if source is defined
sashankaryal Dec 17, 2024
d9e5f38
bump brain version
brimoor Dec 17, 2024
3d5bd81
Merge pull request #5290 from voxel51/bump-brain
brimoor Dec 18, 2024
da08841
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 18, 2024
d872a3b
similarity race condition patch
ehofesmann Dec 13, 2024
4fdcc9c
lint
brimoor Dec 18, 2024
ec2c2e8
Merge pull request #5273 from voxel51/bugfix/sim-sort-patch
brimoor Dec 18, 2024
4aa7000
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 18, 2024
2115658
Merge pull request #5289 from voxel51/fix/detections-sources
sashankaryal Dec 18, 2024
6f49543
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 18, 2024
5603258
model evaluation load_view bug fixes
imanjra Dec 18, 2024
ae494a5
Merge pull request #5268 from voxel51/model-eval-fixes2
brimoor Dec 18, 2024
4d83471
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 18, 2024
ff0c2e7
Merge pull request #4987 from voxel51/zoo_gpu
danielgural Dec 18, 2024
01807ac
decode png header to know num channels
sashankaryal Dec 18, 2024
b86906a
use const png signature
sashankaryal Dec 18, 2024
b4acf0f
remove invalid tests
sashankaryal Dec 18, 2024
d9649c3
Merge pull request #5294 from voxel51/fix/png-decoding
sashankaryal Dec 18, 2024
480780f
Merge branch 'merge/release/v1.2.0' of https://github.com/voxel51/fif…
voxel51-bot Dec 18, 2024
b81c1e7
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 18, 2024
94c3fe9
Reset to initial buffers in video looker (#5293)
benjaminpkane Dec 18, 2024
888ad9d
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 18, 2024
c82bb81
Fix cached looker font sizes (#5287)
benjaminpkane Dec 18, 2024
d8b5a19
Merge branch 'release/v1.2.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Dec 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import { West } from "@mui/icons-material";
import { Box, Button, Card, Stack, Typography } from "@mui/material";
import React from "react";
import ErrorIcon from "./ErrorIcon";

export default function Error(props: ErrorProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Rename component to avoid shadowing global Error

The component name shadows the global Error constructor which could lead to confusion.

-export default function Error(props: ErrorProps) {
+export default function EvaluationError(props: ErrorProps) {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
export default function Error(props: ErrorProps) {
export default function EvaluationError(props: ErrorProps) {
🧰 Tools
🪛 Biome (1.9.4)

[error] 6-6: Do not shadow the global "Error" property.

Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.

(lint/suspicious/noShadowRestrictedNames)

const { onBack } = props;
return (
<Stack sx={{ height: "100%", p: 2 }} spacing={1}>
<Box>
<Button onClick={onBack} startIcon={<West />} color="secondary">
Back to Model Evaluation
</Button>
</Box>
<Card
sx={{
display: "flex",
justifyContent: "center",
alignItems: "center",
height: "100%",
}}
>
<Stack spacing={2} sx={{ alignItems: "center" }}>
<ErrorIcon sx={{ fontSize: 64 }} />
<Typography color="secondary">
Analyze and improve models collaboratively with your team
</Typography>
<Typography sx={{ fontWeight: 600 }}>
The Model Evaluation panel currently supports only classification,
detection, and segmentation evaluations
</Typography>
</Stack>
</Card>
</Stack>
);
}

type ErrorProps = {
onBack: () => void;
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { SvgIcon, SvgIconProps } from "@mui/material";
import React from "react";

export default function ErrorIcon(props: SvgIconProps) {
return (
<SvgIcon width="54" height="61" viewBox="0 0 54 61" fill="none" {...props}>
<path
d="M27 3.16667C34.0667 3.16667 40.6667 3.9 45.5334 5.23333C48.4667 6.03333 50 6.83333 50.6667 7.3V53.7C50.0667 54.1667 48.5334 54.9667 45.5334 55.7667C40.6667 57.1 34.0667 57.8333 27 57.8333C19.9334 57.8333 13.3334 57.1 8.46669 55.7667C5.53335 54.9667 4.00002 54.1667 3.33335 53.7V7.3C3.93335 6.83333 5.46669 6.03333 8.46669 5.23333C13.3334 3.9 19.9334 3.16667 27 3.16667ZM27 0.5C19.7334 0.5 12.8667 1.23333 7.73335 2.63333C2.86669 3.96667 0.666687 5.56667 0.666687 6.56667V54.4333C0.666687 55.4333 2.86669 57.0333 7.73335 58.3667C12.8667 59.7 19.7334 60.5 27 60.5C34.2667 60.5 41.1334 59.7 46.2667 58.3667C51.1334 57.0333 53.3334 55.4333 53.3334 54.4333V6.56667C53.3334 5.56667 51.1334 3.96667 46.2667 2.63333C41.1334 1.23333 34.2667 0.5 27 0.5Z"
fill="#FFC59B"
/>
<path
d="M18.2664 27.6333C14.3331 27.6333 11.0664 24.4333 11.0664 20.4333C11.0664 16.4333 14.3331 13.2999 18.2664 13.2999C22.1997 13.2999 25.3997 16.4999 25.3997 20.4333C25.3997 24.3666 22.1997 27.6333 18.2664 27.6333ZM18.2664 15.9666C15.7997 15.9666 13.7331 17.9666 13.7331 20.4999C13.7331 23.0333 15.7331 25.0333 18.2664 25.0333C20.7997 25.0333 22.7997 23.0333 22.7997 20.4999C22.7997 17.9666 20.7331 15.9666 18.2664 15.9666Z"
fill="#FFC59B"
/>
<path
d="M35.7332 27.6333C31.7999 27.6333 28.5332 24.4333 28.5332 20.4333C28.5332 16.4333 31.7332 13.2333 35.7332 13.2333C39.7332 13.2333 42.9332 16.4999 42.9332 20.4333C42.9332 24.3666 39.6665 27.6333 35.7332 27.6333ZM35.7332 15.9666C33.2665 15.9666 31.1999 17.9666 31.1999 20.4999C31.1999 23.0333 33.1999 25.0333 35.7332 25.0333C38.2665 25.0333 40.2665 23.0333 40.2665 20.4999C40.2665 17.9666 38.1999 15.9666 35.7332 15.9666Z"
fill="#FFC59B"
/>
<path
d="M18.2666 21.9C19.0766 21.9 19.7332 21.2434 19.7332 20.4333C19.7332 19.6233 19.0766 18.9667 18.2666 18.9667C17.4565 18.9667 16.7999 19.6233 16.7999 20.4333C16.7999 21.2434 17.4565 21.9 18.2666 21.9Z"
fill="#FFC59B"
/>
<path
d="M35.7334 21.9C36.5434 21.9 37.2 21.2434 37.2 20.4333C37.2 19.6233 36.5434 18.9667 35.7334 18.9667C34.9233 18.9667 34.2667 19.6233 34.2667 20.4333C34.2667 21.2434 34.9233 21.9 35.7334 21.9Z"
fill="#FFC59B"
/>
<path
d="M20.7333 41.2333C20.9333 40.9666 21.6 40.8333 21.9333 40.7666C22.5333 40.7 22.9333 40.9666 23.2 41.5C23.9333 43.0333 26.2666 41.7 25.5333 40.1666C24.2666 37.6333 19.9333 37.3666 18.4666 39.9C17.5333 41.4333 19.8666 42.7666 20.7333 41.2333Z"
fill="#FFC59B"
/>
</SvgIcon>
);
}
Loading
Loading