always disable orchestrator registration

[swheaton]

Always disable orchestrator_registration in OSS

Summary by CodeRabbit

• Bug Fixes
  • Simplified the orchestrator registration logic to always return False, ensuring consistent behavior regardless of environment settings.

[coderabbitai]

Walkthrough

The changes in this pull request modify the ExecutionOptions class within the fiftyone/operators/executor.py file. The orchestrator_registration_enabled property has been updated to always return False, eliminating the previous logic that checked the FIFTYONE_ENABLE_ORCHESTRATOR_REGISTRATION environment variable. This adjustment simplifies the control flow by ensuring orchestrator registration is consistently disabled.

Changes

File Path	Change Summary
fiftyone/operators/executor.py	Updated orchestrator_registration_enabled property to always return False, removing the environment variable check.

Possibly related PRs

• fix FIFTYONE_ENABLE_ORCHESTRATOR_REGISTRATION warning behavior #5036: The changes in this PR also relate to the FIFTYONE_ENABLE_ORCHESTRATOR_REGISTRATION environment variable, focusing on warning behavior, which connects to the simplification of orchestrator registration handling in the main PR.

Suggested reviewers

• minhtuev
• CamronStaley
• ritch

Poem

In the code where rabbits play,
Orchestrator's kept at bay.
No more checks, just simple flow,
A little change, now watch it glow!
With every hop, our code's refined,
A smoother path, for all aligned. 🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a07b12c and 60328df.

📒 Files selected for processing (1)

• fiftyone/operators/executor.py (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• fiftyone/operators/executor.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[CamronStaley]

Approving since I believe these are OSS only (could maybe add a comment to say that it's OSS specific to avoid someone picking this if there's a merge conflict in the future)