Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for importing/exporting confidence in YOLO formats #1465

Merged
merged 1 commit into from
Dec 26, 2021

Conversation

Rusteam
Copy link
Contributor

@Rusteam Rusteam commented Dec 9, 2021

What changes are proposed in this pull request?

YOLOv4 and YOLOv5 import/export with confidence. Issue

How is this patch tested? If it is not, please explain why.

Assert equal detection confidence bounds between base and after export/import.
Updated tests in tests/unittests/import_export_tests.py to handle default include_confidence=False
and non-default include_confidence=True cases in test_yolov4_dataset and test_yolov5_dataset

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

Set include_confidence=False when exporting a dataset in YOLOv4/YOLOv5 formats to include confidence.
Importing datasets in YOLOv4/YOLOv5 formats automatically loads confidence if it's present in a txt file with detections.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@brimoor brimoor self-requested a review December 12, 2021 16:42
@brimoor brimoor self-assigned this Dec 12, 2021
@brimoor brimoor added the enhancement Code enhancement label Dec 12, 2021
@Rusteam
Copy link
Contributor Author

Rusteam commented Dec 26, 2021

any updates on this one?

@brimoor brimoor changed the title import and export yolov5 datasets with confidence (optional), update tests and docs Adding support for importing/exporting confidence in YOLO formats Dec 26, 2021
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this feature @Rusteam!

And special thanks for including the unit tests 💯

@brimoor brimoor merged commit d65c9cc into voxel51:develop Dec 26, 2021
@Rusteam Rusteam deleted the yolo-conf branch December 27, 2021 05:54
@Rusteam
Copy link
Contributor Author

Rusteam commented Dec 27, 2021

thanks for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants