fix scatter plot events

voxel51 · Aug 1, 2024 · e22eb80 · e22eb80
1 parent 830c789
commit e22eb80
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/app/packages/core/src/plugins/SchemaIO/components/PlotlyView.tsx b/app/packages/core/src/plugins/SchemaIO/components/PlotlyView.tsx
@@ -17,9 +17,7 @@ export default function PlotlyView(props) {
   let range = [0, 0];
   const triggerPanelEvent = usePanelEvent();
   const handleEvent = (event?: string) => (e) => {
-    // TODO: add more interesting/useful event data
     const data = EventDataMappers[event]?.(e) || {};
-    const x_data_source = view.x_data_source;
     let xValue = null;
     let yValue = null;
     if (event === "onClick") {
@@ -37,9 +35,12 @@ export default function PlotlyView(props) {
           range = [xValue - xBinsSize / 2, xValue + xBinsSize / 2];
         } else if (type === "scatter") {
           selected.push(p.pointIndex);
+          xValue = p.x;
+          yValue = p.y;
         } else if (type === "bar") {
           xValue = p.x;
           yValue = p.y;
+          range = [p.x, p.x + p.width];
         } else if (type === "heatmap") {
           xValue = p.x;
           yValue = p.y;
@@ -52,25 +53,30 @@ export default function PlotlyView(props) {
 
     const eventHandlerOperator = view[snakeCase(event)];
 
+    const defaultParams = {
+      path: props.path,
+      relative_path: props.relativePath,
+      schema: props.schema,
+      view,
+      event,
+    };
+
     if (eventHandlerOperator) {
       let params = {};
       if (event === "onClick") {
         params = {
-          event,
-          data,
-          x_data_source,
+          ...defaultParams,
           range,
-          type: view.type,
           x: xValue,
           y: yValue,
         };
       } else if (event === "onSelected") {
         params = {
-          event,
+          ...defaultParams,
           data,
-          type: view.type,
         };
       }
+
       triggerPanelEvent(panelId, {
         operator: eventHandlerOperator,
         params,