Add detach to spotlight (#5157)

* add detach to spotlight * typo
voxel51 · Nov 20, 2024 · 453fbd0 · 453fbd0
1 parent 2ae21fe
commit 453fbd0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/app/packages/core/src/components/Grid/Grid.tsx b/app/packages/core/src/components/Grid/Grid.tsx
@@ -62,6 +62,10 @@ function Grid() {
         looker?.destroy();
         lookerStore.delete(id.description);
       },
+      detach: (id) => {
+        const looker = lookerStore.get(id.description);
+        looker?.detach();
+      },
       onItemClick: setSample,
       retainItems: true,
       rowAspectRatioThreshold: threshold,

diff --git a/app/packages/spotlight/src/row.ts b/app/packages/spotlight/src/row.ts
@@ -120,7 +120,7 @@ export default class Row<K, V> {
   }
 
   destroy(destroyItems = false) {
-    destroyItems && this.#destroyItems();
+    this.#destroyItems(destroyItems);
     this.#aborter.abort();
   }
 
@@ -231,8 +231,8 @@ export default class Row<K, V> {
     return set.size === ONE ? this.#row[ZERO].item.aspectRatio : null;
   }
 
-  #destroyItems() {
-    const destroy = this.#config.destroy;
+  #destroyItems(destroyItems = false) {
+    const destroy = destroyItems ? this.#config.destroy : this.#config.detach;
     if (!destroy) {
       return;
     }

diff --git a/app/packages/spotlight/src/types.ts b/app/packages/spotlight/src/types.ts
@@ -58,6 +58,7 @@ export type Request<K, V> = (key: K) => Promise<{
 export interface SpotlightConfig<K, V> {
   at?: At;
   destroy?: (id: ID) => void;
+  detach?: (id: ID) => void;
   get: Get<K, V>;
   key: K;
   offset?: number;