Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Sphinx dependency from main package #515

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Jun 21, 2021

Resolves #513.

Refactors heavier dependencies like Sphinx that are only required when using ETA's pipeline features into a new [pipeline] extras package.

Also adds some additional features to install_package(), ensure_package(), and ensure_import() that are used by voxel51/fiftyone#1059.

git clone https://github.com/voxel51/eta
cd eta

# lite installation
pip install -e .
import eta.core.utils as etau

etau.ensure_package(["numpy", "scipy"])  # success
etau.ensure_import(["numpy", "scipy"])  # success

etau.ensure_package(["numpyyy", "scipy>1000"])  # helpful error
etau.ensure_import(["numpyyy", "scipy>1000"])  # helpful error
# do something that requires [pipeline] extras
eta modules --metadata eta/modules/sample_videos.py  # helpful error

pip install -e .[pipeline]

eta modules --metadata eta/modules/sample_videos.py  # works

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminpkane benjaminpkane merged commit 6b74060 into develop Jun 21, 2021
@benjaminpkane benjaminpkane deleted the no-sphinx branch June 21, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Remove Sphinx dependency
2 participants