[Bugfix] Fix encoding #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this fixes #94 ? :) |
Hey, I'll inform You when the issue is resolved 🚀🚀 |
darekg11
reviewed
Nov 7, 2021
packages/sdk/src/helpers.ts
Outdated
| @@ -50,7 +50,7 @@ export function assert(condition: any, message?: string): asserts condition { | |||
| throw new Error(message) | |||
| } | |||
|
|
|||
| export function toQueryParams(obj: Record<string, unknown>): Record<string, string> { | |||
| export function toQueryParams(obj: Record<string, unknown> | any): Record<string, string> { | |||
There was a problem hiding this comment.
Is this change really necessary?
darekg11
approved these changes
Nov 7, 2021
|
@alex-all3dp Yes, this is meant to fix encoding query params in Client Side SDK. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.3.0 enabled encoding in
RequestController- it was used to fix encoding for both server side and client side SDKs. This introduced issue, as we did not notice that ClientSide get methods were explicitly encoding query params (toQueryParamsfunction). That meant the query params were encoded twice and that lead to issues with characters such as %.