-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add idtoken response #71
Closed
simongottschlag
wants to merge
9
commits into
vouch:master
from
simongottschlag:add_idtoken_response
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c3ea803
Fix cookies (#3)
simongottschlag 957647b
change encoding to support adfs (#4)
simongottschlag 2dfcccd
Add initial support for ADFS (#5)
simongottschlag b09bad1
Add response headers for /validate with id_token and access_token
08f946c
Add response headers for /validate with id_token and access_token (#6)
simongottschlag f8a704f
Add resource to ADFS redirect.
simongottschlag aa90268
Add resource to ADFS redirect
simongottschlag 313fbb3
remove cookie fix (#9)
simongottschlag 2c9be31
add idToken and accessToken to config example
simongottschlag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,8 +21,10 @@ import ( | |
|
||
// VouchClaims jwt Claims specific to vouch | ||
type VouchClaims struct { | ||
Username string `json:"username"` | ||
Sites []string `json:"sites"` // tempting to make this a map but the array is fewer characters in the jwt | ||
Username string `json:"username"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've been wondering if this should be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No opinion from my side! :) |
||
Sites []string `json:"sites"` // tempting to make this a map but the array is fewer characters in the jwt | ||
IDToken string `json:"id_token"` | ||
AccessToken string `json:"access_token"` | ||
jwt.StandardClaims | ||
} | ||
|
||
|
@@ -53,6 +55,8 @@ func CreateUserTokenString(u structs.User) string { | |
claims := VouchClaims{ | ||
u.Username, | ||
Sites, | ||
u.IDToken, | ||
u.AccessToken, | ||
StandardClaims, | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,6 +26,8 @@ func init() { | |
lc = VouchClaims{ | ||
u1.Username, | ||
Sites, | ||
u1.IDToken, | ||
u1.AccessToken, | ||
StandardClaims, | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this should be in #68 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should! I'm going to try and move it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnfinet I've been able to add it to #68, but I don't think I'll be able to create a PR for idToken without ADFS support (since that's what I'm using).