Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with openresty examples #107

Merged
merged 48 commits into from
Jul 16, 2019
Merged

Update readme with openresty examples #107

merged 48 commits into from
Jul 16, 2019

Conversation

artagel
Copy link
Contributor

@artagel artagel commented Apr 16, 2019

With OpenResty, we can offload all authorization functions from vouch and keep it lean and focused. I think we should provide a couple of common examples to provide to users.
The readme is starting to get busy... perhaps it is time for a wiki, and we can add it there instead?

artagel and others added 30 commits April 14, 2019 19:27
Add headers for accesstoken and idtoken.
…'session' cookies, or cookies that delete after browser is closed.
Implement goreportcard recommendations.
Implement upstream repo changes.
artagel and others added 17 commits May 2, 2019 10:54
…) specifically allows setting of 'authorized' clients, without this setting the client_secret is not needed. ADFS also only requires client_secret for server applications, and other clients do not need it, and error if they receive it.
…agel/vouch-proxy into artagel-general_fixes_and_unit_testing
@bnfinet
Copy link
Member

bnfinet commented May 22, 2019

I'm going to truncate the examples a bit so it's not redundant with the existing Nginx example

would you care to host a gist of the original which we would link to in the README?

…om/artagel/vouch-proxy into artagel-add_openresty_authorization_examples
@bnfinet
Copy link
Member

bnfinet commented May 22, 2019

@artagel I made some adjustments when I merged, please do take a look and let me know what you think

@artagel
Copy link
Contributor Author

artagel commented May 30, 2019

I think it all looks good.

@bjornicus
Copy link

I'm going to truncate the examples a bit so it's not redundant with the existing Nginx example

would you care to host a gist of the original which we would link to in the README?

Did that gist ever get created? I tried pasting the lua snippets into my nginx config and it's not working; I don't see how it's calling vouch at all so I suspect I'm missing some important context which the full config would make clear.

@artagel
Copy link
Contributor Author

artagel commented Jul 31, 2019

I have some better formatted examples I’ll try to push this weekend.
You need to ensure you use openresty, which is nginx compiled with lua, otherwise nothing will work :)

@artagel
Copy link
Contributor Author

artagel commented Jul 31, 2019

#137 Has the examples I was talking about.

@bjornicus
Copy link

Yes, definitely using openresty :)

Thanks, these full examples are exactly I was hoping existed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants