Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it is safer if the jwt.secret is not set by default #8

Merged
merged 4 commits into from
Mar 13, 2021
Merged

it is safer if the jwt.secret is not set by default #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf329b7
it is safer if the jwt.secret is not set by default
punkle Feb 5, 2021
e0b2c06
fails the helm templating if a secret is not provided
punkle Mar 12, 2021
f986fe0
bump version to 2.0.0
punkle Mar 13, 2021
294f99d
Update Chart.yaml
halkeye Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: v1
appVersion: "0.17.3"
description: An SSO and OAuth login solution for nginx using the auth_request module
name: vouch
version: 1.0.0
version: 1.1.0
icon: https://avatars0.githubusercontent.com/u/45102943?s=200&v=4
sources:
- https://github.com/vouch/vouch-proxy/
Expand Down
3 changes: 3 additions & 0 deletions templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{{- if not .Values.existingSecretName }}
{{- if (lt (len .Values.config.vouch.jwt.secret) 1) }}
{{ fail "`config.vouch.jwt.secret` is not set and we are no longer providing a weak default" }}
{{- end }}
apiVersion: v1
kind: Secret
metadata:
Expand Down
2 changes: 1 addition & 1 deletion values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ config:
allowAllUsers: false
whiteList: []
jwt:
secret: super-secret-stuff
secret: ''
testing: false

oauth:
Expand Down