Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image command and args in deployment template #6

Merged
merged 3 commits into from
Mar 13, 2021

Conversation

tidalf
Copy link
Contributor

@tidalf tidalf commented Dec 20, 2020

It adds command and args in the deployment template, that way it's possible to specify a custom entrypoint (for secret injection for instance)

@tidalf tidalf force-pushed the master branch 2 times, most recently from 4b838a2 to bad862e Compare December 20, 2020 13:54
@halkeye
Copy link
Member

halkeye commented Dec 21, 2020

I mean assuming it works it looks fine, but can you add a comment or something to the values or readme describing your scenario?

Also bump the version number?

@tidalf
Copy link
Contributor Author

tidalf commented Dec 28, 2020

I've added a comment and bumped the version.
Tell me if it makes sense :)

Thanks!

@halkeye
Copy link
Member

halkeye commented Dec 28, 2020

sounds good, i'll try and confirm tomorrow it works right, then i'll merge.
It looks good, I'm just afraid of value of [] skips using the entrypoint and stuff

@halkeye halkeye merged commit 6bd6aa4 into vouch:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants