Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extraEnvVars option to add environment variables to the vouch deployment #27

Merged
merged 3 commits into from
Jul 8, 2022
Merged

Conversation

mischmi2
Copy link
Contributor

@mischmi2 mischmi2 commented Mar 15, 2022

This feature add allows you to use the vouch proxy helm chart in environments that require HTTP_PROXY and HTTPS_PROXY to be set for outgoing requests, which is necessary to validate JWT tokens against the configured oauth server.

Relates to vouch/vouch-proxy#291

punkle
punkle previously approved these changes Jul 1, 2022
@punkle
Copy link
Contributor

punkle commented Jul 1, 2022

I am struggling to understand why the github actions seem to be running on my pull requests but not this one.

@punkle
Copy link
Contributor

punkle commented Jul 1, 2022

I didnt mean to your master branch, sorry about that @mischmi2. Would you mind resolving these merge conflicts and we'll get it merged asap. Apologies for the delay in addressing this.

@mischmi2
Copy link
Contributor Author

mischmi2 commented Jul 7, 2022

@punkle I've fetched origin and resolved the merge conflicts with master branch.

@bnfinet
Copy link
Member

bnfinet commented Jul 7, 2022

I am struggling to understand why the github actions seem to be running on my pull requests but not this one.

Do let me know if there's anything I can look into or if I can help in any way. Cheers!

@punkle
Copy link
Contributor

punkle commented Jul 8, 2022

@bnfinet I think it asks a member of the organisation to trigger the builds manually for pull requests coming from external users. I can see how this might be desirable. I would say leave it in place. It is not a terrible inconvenience having to trigger the build manually for external pull requests. Thoughts?

@punkle punkle merged commit 3c5ef6c into vouch:master Jul 8, 2022
@bnfinet
Copy link
Member

bnfinet commented Jul 8, 2022

Yeah that makes perfect sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants