always allow polls transitions when continuous export is disabled #5580
Conversation
There was a problem hiding this comment.
Thank you for fixing!
Also just confirming that I did test that, on v3.1.2, polls can be closed without a USB drive inserted if continuous export is disabled, per the v3.1.2 QA checklist.
On v3.1.2, I did not test polls open and polls pause without a USB drive and continuous export disabled, so it's possible that those still require a USB drive. But ultimately, it's polls close that's the most important operation to make sure is unblocked.
| <UsbDriveAlertText usbDriveStatus={usbDriveStatus} /> | ||
| <UsbDriveAlertText | ||
| mustInsertUsbDriveToContinue={mustInsertUsbDriveToContinue} | ||
| /> |
There was a problem hiding this comment.
nit: Rather than having UsbDriveAlertText internally render null when mustInsertUsbDriveToContinue is false, I think the code may read clearer if we pull that check out of the component, i.e.
{mustInsertUsbDriveToContinue && <UsbDriveAlertText />}There was a problem hiding this comment.
addressed in follow-up commit
) (#5584) * always allow polls transitions when continuous export is disabled * PR feedback
Overview
Closes #5579.