Improve smart card illustrations #5418
Merged
+151
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pause on reviewing this please - I realized I need to also update RemoveCardImage |
jonahkagan
force-pushed
the
jonah/insert-card-image-redesign
branch
from
19cb578
to
1703d63
Compare
- Make it transparent so it works on any background color - Add rotation options for machines with different card reader locations - Remove the card reader bevel and replaced with a generic line slot
jonahkagan
force-pushed
the
jonah/insert-card-image-redesign
branch
from
1703d63
to
b7c871a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Demo Video or Screenshot
Before
After
Screen.Recording.2024-09-19.at.10.37.30.AM.mov
Testing Plan
Manual testing
Checklist