VxAdmin: Only show card programming modal on smart cards screen #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, add the smart cards screen to the system admin left nav when unconfigured (to maintain the existing ability to program sys admin cards without configuring the machine). Note that currently the smart cards screen will have some misleading copy about creating election cards when unconfigured, but I'll be updating that screen in the next PR, so it's just a momentary issue.
jonahkagan
requested review from
a team and
eventualbuddha
and removed request for
a team
eventualbuddha
approved these changes
Sep 19, 2024
jonahkagan
deleted the
jonah/only-show-card-programming-modal-on-smartcard-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Short term fix for #5388
Instead of showing the card programming modal on any screen when logged in as a sys admin, only show it on the smart cards screen. This will prevent users from accidentally resetting their system admin card PIN.
In addition, add the smart cards screen to the system admin left nav when unconfigured (to maintain the existing ability to program sys admin cards without configuring the machine). Note that currently the smart cards screen will have some misleading copy about creating election cards when unconfigured, but I'll be updating that screen in the next PR, so it's just a momentary issue.
Demo Video or Screenshot
Screen.Recording.2024-09-18.at.12.44.49.PM.mov
Testing Plan
Manual test and updated automated tests
Checklist