chore(deps): remove some unused CRA deps #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we don't use `webpack`, so no `-loader`s are needed - we don't use `postcss` except for `postcss-styled-syntax` - we don't use `ts-pnp`, so we can remove that dependency and the config files - we use `react-refresh` through `@vitejs/plugin-react`, so we don't need to depend on it directly
eventualbuddha
requested review from
arsalansufi
and removed request for
a team
eventualbuddha
changed the title
arsalansufi
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
webpack, so no-loaders are neededpostcssexcept forpostcss-styled-syntaxts-pnp, so we can remove that dependency and the config filesreact-refreshthrough@vitejs/plugin-react, so we don't need to depend on it directlyDemo Video or Screenshot
n/a
Testing Plan
Tested that fast refresh still works in VxMark.