This repository has been archived by the owner on Oct 29, 2020. It is now read-only.
refactor: replace canvas with sharp #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvas does not support being loaded in worker threads due to it being a native dependency that was not written using a thread-compatible API. sharp, on the other hand, is thread-aware: lovell/sharp#1558.
eventualbuddha
commented
Sep 29, 2020
| @@ -1614,7 +1614,7 @@ test('interpret votes', async () => { | |||
| }, | |||
| Object { | |||
| "option": "Jane Bland", | |||
| "score": 0.5717884130982368, | |||
| "score": 0.5714285714285714, | |||
There was a problem hiding this comment.
The decoding of images is slightly different between canvas and sharp, so we get different scores.
benadida
approved these changes
Sep 29, 2020
Merged
eventualbuddha
added a commit
to votingworks/module-scan
that referenced
this pull request
Sep 29, 2020
eventualbuddha
added a commit
to votingworks/module-scan
that referenced
this pull request
Sep 29, 2020
eventualbuddha
added a commit
to votingworks/vxsuite
that referenced
this pull request
Oct 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canvas does not support being loaded in worker threads due to it being a native dependency that was not written using a thread-compatible API. sharp, on the other hand, is thread-aware: lovell/sharp#1558.