Feature/issue 384 52 revision #386
Conversation
… Moves XML example from LatLng to PollingLocation.
…lingLocation XML example.
| id,name,address_line,directions,hours,photo_uri,hours_open_id,is_drop_box,is_early_voting,latitude,longitude,latlng_source | ||
| poll001,ALBERMARLE HIGH SCHOOL","2775 Hydraulic Rd Charlottesville, VA 22901,Use back door,7am-8pm,www.picture.com,ho001,false,true,38.0754627,78.5014875,Google Maps | ||
| id,name,address_line,structured_location_name,structured_line_1,structured_city,structured_state,structured_zip,directions,hours,photo_uri,hours_open_id,is_drop_box,is_early_voting,latitude,longitude,latlng_source | ||
| poll001,ALBERMARLE HIGH SCHOOL","2775 Hydraulic Rd Charlottesville, VA 22901,ALBERMARLE HIGH SCHOOL,2775 Hydraulic Rd,Charlottesville,VA,22901,Use back door,7am-8pm,www.picture.com,ho001,false,true,38.0754627,78.5014875,Google Maps |
There was a problem hiding this comment.
This doesn't seem to be a valid example. It has both address_line and the structured address. Plus I'm not sure what the quotations are doing here.
There was a problem hiding this comment.
Will clean this up. It is a bad example.
| @@ -67,6 +67,14 @@ are equal. | |||
| | | | | | **IncludesAllStreets** are true, this | | | |||
| | | | | | value is ignored. | | | |||
| +------------------------+---------------------------+--------------+--------------+------------------------------------------+------------------------------------------+ | |||
| | house_number_prefix | ``xs:string`` | Optional | Single | Part of a street address. It may contain | If the field is not present of invalid, | | |||
There was a problem hiding this comment.
I'd like to discuss these more before adding them.
| @@ -57,6 +57,14 @@ | |||
| | | | | | **IncludesAllStreets** are true, this | | | |||
| | | | | | value is ignored. | | | |||
| +----------------------+---------------------------+--------------+--------------+------------------------------------------+------------------------------------------+ | |||
| | HouseNumberPrefix | ``xs:string`` | Optional | Single | Part of a street address. It may contain | If the field is not present of invalid, | | |||
There was a problem hiding this comment.
Same here. We need guidance on what these mean before adding them. See my comments/requests on #162.
| @@ -3,23 +3,6 @@ csv-header-name: lat_long | |||
| description: |- | |||
| The latitude and longitude of a polling location in `WGS 84`_ format. Both | |||
| latitude and longitude values are measured in decimal degrees. | |||
| post: |- | |||
There was a problem hiding this comment.
Why was this block removed?
There was a problem hiding this comment.
This PollingLocation XML example post was relocated from the lat_long.yaml to the polling_location.yaml file.
| @@ -112,6 +112,22 @@ tags: | |||
| **StartHouseNumber**, the implementation should ignore the element containing | |||
| it. | |||
| type: xs:integer | |||
| - _name: HouseNumberPrefix | |||
There was a problem hiding this comment.
See other comments about needing to resolve issues around #162 before adding this to the spec.
This PR references the following open Issues:
#351
#162
#377
#367
This is a first pass at the 5.2 revision. Comments and suggestions are welcomed and encouraged.