-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added guide for potential contributors #100
Conversation
One thought: I was thinking this could go in the docs directory alongside the style guide. (The "best practices" guide for feeds could also go in the docs directory.) For more visibility, you could link to how to contribute in the README (GitHub supports internal relative links, e.g. |
One more thought: you might want to link to the style guide in the contributing doc (e.g. in the bullets for creating a pull request). |
@cjerdonek Personally, I like the idea of |
@jungshadow I see your point about maintaining a distinction between external-facing docs and internal project docs, something I agree with. I guess my point was more that when you start having more than one of something (e.g. "contributing" and "style guide"), I usually create a folder for it so as not to clutter the top level. I was making a distinction between the history file and other internal project docs. |
I talked bit with @demcg about this on Friday and I believe we're of the same mind on this. On a related note, I'd like to create a separate repository to house the documentation, which will help with hosting/building this on Read the Docs. Any other thoughts on this? /cc @pstenbjorn @jdmgoogle @pkoms @nomadaisy |
@jungshadow I agree with using Read the Docs and having a separate Doc repo. |
I'd strongly recommend keeping the docs in the same repo as the spec. (This is also how most projects that I'm familiar with do it, as well as what Read The Docs says to do in their documentation.) A couple advantages of doing it this way are that 1) the docs stay in synch with the version of the spec they are documenting (even when creating feature branches, etc), and 2) doc changes can be committed simultaneously with spec changes (which means you don't need to cross repos when adding to or viewing changes to the docs). |
@cjerdonek I didn't see a hard-and-fast recommendation in the Read the Docs documentation, but that sounds reasonable. Additionally, we can add to So here's the plan:
Assuming that all makes sense, I'll merge today. |
@jungshadow okay, thanks. By the way, if you find that Markdown isn't flexible enough in terms of layout and styling options (e.g. in the way of providing what you already have here), another possibility to look at for the longer term would be auto-generating the bulk of the HTML using templates. For example, you could have an HTML template snippet for a single object type. This would let you change the global structure and look-and-feel more easily by modifying things in one place. This would take a bit more work to set up though, so would be a longer term project. |
cbb28ca
to
f31a55f
Compare
…ng-guide Added guide for potential contributors
I only merged |
This should close #93 when merged.