Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style guide should state the "Other" pattern used with enums #106

Closed
cjerdonek opened this issue Apr 19, 2015 · 4 comments
Closed

Style guide should state the "Other" pattern used with enums #106

cjerdonek opened this issue Apr 19, 2015 · 4 comments
Labels
documentation enhancement
Milestone
Version 5.0 Docum...

Comments

@cjerdonek
Copy link
Contributor

The style guide should describe the following pattern used throughout the spec of adding an "Other" element with type xs:string whenever we want to allow values not included in an enumeration:

<xs:element name="VoteVariationType" type="VoteVariation" minOccurs="0" />
<xs:element name="OtherVoteVariationType" type="xs:string" minOccurs="0" />
@jungshadow jungshadow added this to the Version 5.0 milestone Apr 20, 2015
cjerdonek added a commit to cjerdonek/vip-specification that referenced this issue Apr 20, 2015
@cjerdonek
Address issue votinginfoproject#106: document "other" used with enums.
cc94fc7
@cjerdonek cjerdonek mentioned this issue Apr 20, 2015
Merged
@cjerdonek
Copy link
Contributor Author

Created PR #115.

@jdmgoogle
Copy link
Contributor

Looks Good To Me

@cjerdonek
Copy link
Contributor Author

Thanks. @pstenbjorn how does this look to you? @jungshadow requested sign off from two people.

cjerdonek added a commit that referenced this issue Apr 23, 2015
@cjerdonek
Merge pull request #115 from votinginfoproject/feature/issue-106-styl…
edadf96 
…e-other-enum

Address issue #106: document style for "other" and enums
@cjerdonek
Copy link
Contributor Author

Closed by PR #115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
Version 5.0 Documentation
Development

No branches or pull requests
3 participants
@jungshadow @cjerdonek @jdmgoogle