Formatting, typos, feedback #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
commented
Oct 6, 2022
| @@ -69,7 +68,7 @@ wagtail start myblog . | |||
|
|
|||
| Don't forget the `.` at the end of the command. It is telling Wagtail to put all of the files in the current working directory. | |||
|
|
|||
| Once all of the files are set up, you'll need to enter some commands to set up the test database and all of the migration files that Wagtail needs. You can do that with the `migrate` command. | |||
| Once all of the files are set up, you'll need to enter some commands to set up the test database and apply all the migrations that Wagtail needs. You can do that with the `migrate` command. | |||
There was a problem hiding this comment.
It’s makemigrations that makes the files, while here we use migrate which only changes the database.
| @@ -110,7 +110,7 @@ python manage.py migrate wagtailcore 0058 | |||
| python manage.py migrate | |||
| ``` | |||
|
|
|||
| These commands revert the `wagtailcore 0059` migration back to `wagtailcore 0058` to prevent the table conflict from occurring. This step should hopefully be unnecessary after the bug is fixed. | |||
| These commands revert the `wagtailcore` migrations back to `wagtailcore 0058` to prevent the table conflict from occurring. This step should hopefully be unnecessary after the bug is fixed. | |||
There was a problem hiding this comment.
Technically we revert all migrations that are more recent than 0058, not just 0059.
| @@ -182,7 +182,7 @@ WAGTAILLOCALIZE_MACHINE_TRANSLATOR = { | |||
| Django's `LocaleMiddleware` detects a user's browser language and forwards them to the most appropriate language | |||
| version of the website. | |||
|
|
|||
| To enable it, insert `'django.middleware.locale.LocaleMiddleware'` into the middleware setting | |||
| To enable it, insert `"django.middleware.locale.LocaleMiddleware"` into the middleware setting | |||
There was a problem hiding this comment.
Note here and in lots of other places – by default the generated site uses single quotes, so those examples differ from wagtail start output. Here I switched to double for consistency with the code below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve stopped here for today, will try to pick this up again tomorrow.
One issue I’ve left in is migrations – when we revert to a specific migration of
wagtailcore, we shouldn’t be runningmigrateright after. Instead, we should only do that after adding localize toINSTALLED_APPS.