Skip to content

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Oct 30, 2025

Note that the formatting is ugly because of this: rust-lang/rust#52234 (comment)

Several of the match statements keep getting out of sync because we have to remember to add variants to match statements everywhere.

Also fixes some of the macro imports since we're macro_exporting everything again.

Also fixes an issue with the struct API (accidentally didn't return an Arc)

(Note that this is quite important for the implementation of FixedSizeList and ListView vectors) otherwise there is way too much boilerplate

@connortsui20 connortsui20 requested review from a10y and gatesn October 30, 2025 15:39
@connortsui20 connortsui20 added the chore Release label indicating a trivial change label Oct 30, 2025
@connortsui20 connortsui20 mentioned this pull request Oct 30, 2025
39 tasks
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.24%. Comparing base (e00961b) to head (9aa9833).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-vector/src/vector_mut.rs 66.66% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
@connortsui20
Copy link
Contributor Author

Do you think that the syntax that I chose here makes sense? I could also add a match literal at the beginning front to make it super obvious

@connortsui20 connortsui20 merged commit 5b91d07 into develop Oct 30, 2025
40 checks passed
@connortsui20 connortsui20 deleted the ct/vv-macro-fix branch October 30, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants