Conversation
gatesn
reviewed
Feb 14, 2025
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
Why don't we just enable the unstable feature?
Contributor
Author
|
makes it harder long term to lower our msrv/move to stable |
Contributor
Author
|
its been unstable for four years now, IDK what's the roadmap to stability and seems like there are still some open questions in that issue |
danking
approved these changes
Feb 14, 2025
Contributor
danking
left a comment
danking
left a comment
There was a problem hiding this comment.
My dear gentleman, I heartily approve.
AdamGS
added a commit
that referenced
this pull request
Feb 14, 2025
Didn't actually check that in #2360, apparently the compiler doesn't like `flatten` becuase it exists in an unstable feature. This PR is dedicated to @danking as the chief [haskeller](https://en.wiktionary.org/wiki/Haskeller).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't actually check that in #2360, apparently the compiler doesn't like
flattenbecuase it exists in an unstable feature.This PR is dedicated to @danking as the chief haskeller.