Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot parse statements with nested subshells #50

Open
dotmpe opened this issue Apr 21, 2018 · 2 comments
Open

Cannot parse statements with nested subshells #50

dotmpe opened this issue Apr 21, 2018 · 2 comments

Comments

@dotmpe
Copy link

dotmpe commented Apr 21, 2018

Scripts that have expressions with multiple subshells fail with

SyntaxError: Unclosed $(

Examples:

scriptpath="$(dirname "$(dirname "$(dirname "$0")")")"
LIB=$(cd $(dirname $(dirname $0)); pwd -P )
dotmpe added a commit to dotmpe/bash-parser that referenced this issue Apr 23, 2018
@dotmpe
Preliminary tests for vorpaljs#45, vorpaljs#50
9976584
dotmpe added a commit to dotmpe/bash-parser that referenced this issue Apr 23, 2018
@dotmpe
Preliminary tests for vorpaljs#45, vorpaljs#50
960e64b
@parro-it
Copy link
Collaborator

Hi @BvBerkum I saw you did some work on your fork?
Would you mind open 2 PR: one with the coverage fixes and linting fixes
and another with the failing tests for this issue?
We can further discuss & fix the multiple subshells issue there.

Thank you!

@dotmpe
Copy link
Author

dotmpe commented Apr 27, 2018

Thanks for reminding me, its easy to forget things once committed. See PR #53 for the linting and coverall change. I have some more changes stashed touching these and another issue, I'll sort out the tests and branch those per issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dotmpe @parro-it