[Fix] Define nullable parameter as nullable

[Baspa]

No description provided.

[faizananwerali]

Issue Description

There is a problem in this part.

public function __invoke(?string $tenant, string $mail, string $attachment, string $filename)

The tenant part in the route is conditionally included from a higher hierarchy route. When tenant is not present, the controller incorrectly resolves the parameters. Specifically, the $mail value is assigned to $tenant, and the rest of the parameters are shifted, causing a mismatch.

For example, the following URL:

https://admin-dev.vec.test/mails/32/attachment/30/sample%20test%208%20-%20Verified.pdf

Fails because $tenant is not included in the route, resulting in a misalignment of the parameters in the controller.

---

Proposed Solution

To handle this scenario, I propose the following changes to dynamically determine if tenant is present and resolve the parameters correctly:

class MailDownloadController extends Controller
{
    public function __invoke(...$arguments)
    {
        if (count($arguments) === 4) {
            [$tenant, $mail, $attachment, $filename] = $arguments;
        } else {
            [$mail, $attachment, $filename] = $arguments;
            $tenant = null;
        }

        $tenant = $tenant ? (string) $tenant : null;
        $mail = (string) $mail;
        $attachment = (string) $attachment;
        $filename = (string) $filename;

        // Handle the request...
    }
}

This solution uses the argument count to determine if tenant is included and ensures the parameters are assigned correctly. It maintains compatibility with routes both with and without tenant.

[Baspa]

@faizananwerali got a new PR ready (#16). Feel free to submit a PR next time! :) Thanks.